Allow ExportObject to be RELEASED When Already Managed #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
devinrsmith
requested changes
Jan 8, 2024
server/src/main/java/io/deephaven/server/session/SessionState.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jan 9, 2024
server/src/main/java/io/deephaven/server/session/SessionState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/session/SessionState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/session/SessionState.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Ryan Caudy <[email protected]>
devinrsmith
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
I've tested, and this does seem to fix #5002 so I'm happy. I'll let others review changes to management semantics.
rcaudy
approved these changes
Jan 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5002.
We intend to allow exports to be
RELEASEDwhile anExportObjectis in limbo waiting for other parent dependencies. The original intent was to increment the reference count duringsetDependenciesto guarantee that if it wasEXPORTEDat that time (or shortly after) that we would be guaranteed to have a validresultuntil theExportObjectwasdestroy()'d -- allowing for the external client toRELEASEwhen convenient and without needing to keep track of these dependencies itself.